[PLT-1018] Add dataset.set_iam_integration() to select/deselect integrations #1622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

paulnoirel merged 16 commits into develop from PNO/set-iam-integration

May 29, 2024

Contributor

paulnoirel commented May 20, 2024 •

edited

Loading

Currently, users can create datasets with the SDK but can't modify the integration outside of the UI. This makes migration projects tedious since no automation is possible.

The current method brings a quick solution to this problem.

With this new method it is possible to:

Set IAM integration for integration id

# Get all IAM integrations
iam_integrations = client.get_organization().get_iam_integrations()

 # Get IAM integration id
iam_integration_id = [integration.uid for integration
   in iam_integrations
   if integration.name == "My S3 integration"][0]

dataset.add_iam_integration(iam_integration_id)

Set IAM integration for IAM integration object

# Get all IAM integrations
iam_integrations = client.get_organization().get_iam_integrations()

 # Get IAM integration object
iam_integration = [integration.uid for integration
   in iam_integrations
   if integration.name == "My S3 integration"][0]
 
dataset.add_iam_integration(iam_integration)

Remove IAM integration

dataset.remove_iam_integration()

paulnoirel added 4 commits

May 20, 2024 19:40


          Add dataset.set_iam_integration() to select/deselect integrations

b96a622


          Fix typo

f85de73


          Merge branch 'develop' into PNO/set-iam-integration

11b684f


          Merge branch 'develop' into PNO/set-iam-integration

f6f2d54

paulnoirel temporarily deployed to Test-PyPI

May 20, 2024 19:22

— with

GitHub Actions Inactive

paulnoirel marked this pull request as ready for review

May 20, 2024 19:26

paulnoirel requested a review from a team as a code owner

May 20, 2024 19:26

sfendell-labelbox reviewed

View reviewed changes

libs/labelbox/src/labelbox/schema/dataset.py Outdated Show resolved Hide resolved

sfendell-labelbox reviewed

View reviewed changes

libs/labelbox/src/labelbox/schema/dataset.py Outdated Show resolved Hide resolved

sfendell-labelbox reviewed

View reviewed changes

libs/labelbox/src/labelbox/schema/dataset.py Outdated Show resolved Hide resolved

sfendell-labelbox reviewed

View reviewed changes

libs/labelbox/src/labelbox/schema/dataset.py Outdated Show resolved Hide resolved

sfendell-labelbox reviewed

View reviewed changes

libs/labelbox/src/labelbox/schema/dataset.py Outdated Show resolved Hide resolved

sfendell-labelbox reviewed

View reviewed changes

libs/labelbox/src/labelbox/schema/dataset.py Outdated Show resolved Hide resolved

sfendell-labelbox reviewed

View reviewed changes

libs/labelbox/tests/integration/test_delegated_access.py Outdated Show resolved Hide resolved

sfendell-labelbox suggested changes

View reviewed changes

Contributor

sfendell-labelbox left a comment

Comments left. LGTM in concept, but some styling/consistency stuff.

paulnoirel added 2 commits

May 21, 2024 20:59


          Split method and rename it. Split tests

16753c7


          Fix indentation

c9b93a6

paulnoirel temporarily deployed to Test-PyPI

May 21, 2024 20:29

— with

GitHub Actions Inactive

paulnoirel requested a review from sfendell-labelbox

May 21, 2024 20:39

sfendell-labelbox reviewed

View reviewed changes

libs/labelbox/src/labelbox/schema/dataset.py Outdated Show resolved Hide resolved

sfendell-labelbox reviewed

View reviewed changes

libs/labelbox/src/labelbox/schema/dataset.py Outdated Show resolved Hide resolved

sfendell-labelbox reviewed

View reviewed changes

libs/labelbox/src/labelbox/schema/dataset.py Outdated Show resolved Hide resolved


          Fix exceptions

b177143

paulnoirel requested a review from sfendell-labelbox

May 21, 2024 23:49

paulnoirel temporarily deployed to Test-PyPI

May 21, 2024 23:59

— with

GitHub Actions Inactive

paulnoirel added 2 commits

May 22, 2024 22:30


          Clean remove_iam_integration()

bb83716


          Merge branch 'develop' into PNO/set-iam-integration

a44cefe

adrian-chang requested a review from a team

May 22, 2024 22:05

sfendell-labelbox previously approved these changes

View reviewed changes

libs/labelbox/src/labelbox/schema/dataset.py Outdated Show resolved Hide resolved


          Remove final space

7c51d6e

paulnoirel dismissed sfendell-labelbox’s stale review via

7c51d6e

May 22, 2024 23:28

paulnoirel requested a review from sfendell-labelbox

May 22, 2024 23:29

sfendell-labelbox previously approved these changes

View reviewed changes

adrian-chang suggested changes

View reviewed changes

libs/labelbox/src/labelbox/schema/dataset.py Show resolved Hide resolved


          Reformat add_iam_integration()

66e98b5

paulnoirel dismissed sfendell-labelbox’s stale review via

66e98b5

May 22, 2024 23:46

paulnoirel requested a review from adrian-chang

May 22, 2024 23:49


          Merge branch 'develop' into PNO/set-iam-integration

eb05457

paulnoirel temporarily deployed to Test-PyPI

May 23, 2024 21:11

— with

GitHub Actions Inactive

paulnoirel temporarily deployed to Test-PyPI

May 23, 2024 21:15

— with

GitHub Actions Inactive


          Merge branch 'develop' into PNO/set-iam-integration

9be2afd

adrian-chang temporarily deployed to Test-PyPI

May 24, 2024 08:33

— with

GitHub Actions Inactive

paulnoirel requested a review from sfendell-labelbox

May 24, 2024 09:08


          Merge branch 'develop' into PNO/set-iam-integration

acb5552

paulnoirel temporarily deployed to Test-PyPI

May 24, 2024 20:07

— with

GitHub Actions Inactive


          Merge branch 'develop' into PNO/set-iam-integration

ece7119

adrian-chang changed the title ~~Add dataset.set_iam_integration() to select/deselect integrations~~ [PLT-1018] Add dataset.set_iam_integration() to select/deselect integrations

Contributor

adrian-chang commented May 25, 2024

@paulnoirel please fill out https://labelbox.atlassian.net/browse/PLT-1018 with some details for QA


          Merge branch 'develop' into PNO/set-iam-integration

210edfd

adrian-chang approved these changes

View reviewed changes

paulnoirel merged commit e3b5b38 into develop

21 of 22 checks passed

paulnoirel deleted the PNO/set-iam-integration branch

May 29, 2024 19:15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet